[https://nvbugs/5527956][fix] AutoDeploy: fix IMA due to outdated metadata - #8002
Conversation
3787b89 to
fe6739c
Compare
|
/bot run |
📝 WalkthroughWalkthroughIntroduces runtime resizing and validation in attention_interface._store_arg and updates nest_sequences to use reset=True when storing page assignment metadata. Also removes one skipped test entry from tests/integration/test_lists/waives.txt. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant H as Host
participant AI as attention_interface._store_arg
participant DT as DeviceTensor
H->>AI: store_arg(host_tensor, device_tensor, reset)
AI->>AI: Check host vs device size
alt reset=True and host > device
AI->>DT: Resize to host size
AI->>DT: Write data
DT-->>AI: OK
else host <= device
AI->>DT: Write data
DT-->>AI: OK
else reset=False and host > device
AI-->>H: Raise ValueError (available vs required)
end
sequenceDiagram
autonumber
participant NS as nest_sequences
participant AI as attention_interface._store_arg
participant DT1 as cache_loc
participant DT2 as pages_per_seq
NS->>AI: store_arg(cache_loc_host, DT1, reset=True)
AI->>DT1: Reset/resize if needed, write
NS->>AI: store_arg(pages_per_seq_host, DT2, reset=True)
AI->>DT2: Reset/resize if needed, write
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/bot run |
|
PR_Github #19972 [ run ] triggered by Bot |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py (1)
554-558: Fix typing for Python 3.8 compatibility (use Union instead of |).The annotation
List[int | float]uses PEP 604 unions, which are 3.10+. Per guidelines, target Python 3.8+. Replace withList[Union[int, float]].Apply this diff:
- tnsr_like: List[int | float], + tnsr_like: List[Union[int, float]],
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py(2 hunks)tests/integration/test_lists/waives.txt(0 hunks)
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/waives.txt
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py
🧬 Code graph analysis (1)
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py (1)
tensorrt_llm/_utils.py (1)
numel(975-976)
🪛 Ruff (0.13.1)
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py
580-583: Avoid specifying long messages outside the exception class
(TRY003)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py (1)
645-647: Verify no implicit dependencies onnum_pages == len(cache_loc)
Grep reveals manycache_locreferences across custom ops and tests; audit slices and loops to ensure decoupling fromnum_pagesdoesn’t break assumptions.
|
PR_Github #19971 [ run ] triggered by Bot |
|
PR_Github #19972 [ run ] completed with state |
fe6739c to
2bd286e
Compare
lucaslie
changed the title
|
/bot run |
|
PR_Github #19976 [ run ] triggered by Bot |
|
PR_Github #19971 [ run ] completed with state |
2bd286e to
1d1045d
Compare
|
/bot run |
|
PR_Github #19979 [ run ] triggered by Bot |
|
PR_Github #19976 [ run ] completed with state |
1eccc57 to
b9dcfa6
Compare
|
/bot kill |
b9dcfa6 to
d9274a6
Compare
|
PR_Github #19981 [ kill ] triggered by Bot |
|
PR_Github #19979 [ run ] completed with state |
|
PR_Github #19981 [ kill ] completed with state |
ff0e15d to
68a8bc5
Compare
…es with better reset/sizing Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
68a8bc5 to
d129d18
Compare
|
/bot run |
|
PR_Github #19991 [ run ] triggered by Bot |
|
PR_Github #19991 [ run ] completed with state |
|
/bot run |
|
PR_Github #19994 [ run ] triggered by Bot |
|
PR_Github #19994 [ run ] completed with state |
|
/bot run |
|
PR_Github #20019 [ run ] triggered by Bot |
|
PR_Github #20019 [ run ] completed with state |
…adata (NVIDIA#8002) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
…adata (NVIDIA#8002) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
…adata (NVIDIA#8002) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
…adata (NVIDIA#8002) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
3 participants
Summary by CodeRabbit
Bug Fixes
Tests
Description
Benchmarking
AutoDeploypost-changesAutoDeploypre-changesPyTorchTest Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.